Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSG-4008 - Demo Features #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PSG-4008 - Demo Features #6

wants to merge 2 commits into from

Conversation

blaynebayer
Copy link

Make Post register prompt, auto login with passkey, and show a login ……with passkey button configurable through environment variables

Description

New environment variables to configure certain features.

  • PASSAGE_DISABLE_PASSKEY_PROMPT_AFTER_REGISTER:
    • Set to true the app will no longer prompt to create a passkey after registering
    • Otherwise the app will prompt to create a passkey after registering
  • PASSAGE_DISABLE_AUTO_LOGIN:
    • Set to true the app will not attempt a login with passkey on login page load
    • Otherwise the app will attempt a login with Passkey on login page load
  • PASSAGE_LOGIN_WITH_PASSKEY_BUTTON:
    • Set to true the app will display a login with passkey button on the login page that will attempt to login with passkey
    • Otherwise the app will not render the login with passkey button

Jira Story

PSG-4008

Images/Screen Capture

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • New documentation

Testing

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@blaynebayer
Make Post register prompt, auto login with passkey, and show a login …
a7583c4 
…with passkey button configurable through environment variables
@blaynebayer blaynebayer requested a review from a team as a code owner May 17, 2024 15:46
flanagankp
flanagankp reviewed May 17, 2024
View reviewed changes
.env.example
PASSAGE_API_KEY=
PASSAGE_DISABLE_PASSKEY_PROMPT_AFTER_REGISTER=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having env variables to configure the flow is cool - though I worry this will over-complicate the source code for others looking at the demo.

The point of the demo app is really to show the one true Passage recommended™ passkey + password flow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we never have to merge this, but a good way to get a review!

@agebhardt agebhardt changed the title PSG-4008 - Notion Demo Features PSG-4008 - Demo Features May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flanagankp flanagankp flanagankp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaynebayer @flanagankp